Ben Mares
Ben Mares
I'd add more tests, for example: * Before a release, fail in case the version number from the tag doesn't match the version reported by `pytensor.__version__`. * Ensure consistency between...
Yes, the first two amount to "check that versioneer isn't screwing something up"
I think :point_up: is desirable behavior because probably it won't work fine. If someone in 2028 wants to use the 2024 PyTensor, they should also be using the 2024 Numpy....
@carlsmedstad, do you have any opinions on this matter? The idea would also be to add automation to ensure the upper pins stay up-to-date.
Also note that unlike #593 I'm only concerned here with runtime dependencies.
Agreed. Putting an upper-bound on the patch version will likely just prevent bugfixes. But I think the current situation of having no upper-bounds at all is pretty bad. Since everyone...
I haven't looked at the error message here yet, but I think I read that upload-artifact and download-artifact are incompatible across different major versions. The download-artifact PR got merged, so...
> Conflict: an artifact with this name already exists on the workflow run Ah, we need to ensure that the artifact names are all unique.
@dependabot rebase
Ooh, excellent, all green!!! :rocket: If you approve, then please squash-merge.