pytensor icon indicating copy to clipboard operation
pytensor copied to clipboard

BUG: No tests exist yet to ensure that packages are being created correctly

Open maresb opened this issue 2 years ago • 5 comments

Describe the issue:

One case where files were missing: #310

The sdist was not finding the correct version number: #293

I think these examples demonstrate the need for some checks regarding the build process.

Reproducable code example:

n/a

Error message:

No response

PyTensor version information:

n/a

Context for the issue:

No response

maresb avatar May 19 '23 13:05 maresb

@maresb do you have ideas for what to do?

ricardoV94 avatar Dec 07 '23 12:12 ricardoV94

Right now this is what we have: https://github.com/pymc-devs/pytensor/blob/main/.github/workflows/pypi.yml

ricardoV94 avatar Dec 07 '23 12:12 ricardoV94

I'd add more tests, for example:

  • Before a release, fail in case the version number from the tag doesn't match the version reported by pytensor.__version__.
  • Ensure consistency between pytensor.__version__ and importlib.metadata.version("pytensor")
  • Verify that mandatory files are being included in the various distributions (separately for both sdists and wheels)

maresb avatar Dec 07 '23 14:12 maresb

Are the first two compatible with the current use of versioneer?

ricardoV94 avatar Dec 07 '23 15:12 ricardoV94

Yes, the first two amount to "check that versioneer isn't screwing something up"

maresb avatar Dec 07 '23 15:12 maresb