Ben Mares comments

Results 675 comments of


                                            Ben Mares

feat: add pypi-to-conda-name overrides to pyproject parsing

Haha, I think at least some of the CI failures may be a timing issue. Look what just dropped: https://github.com/pandas-dev/pandas/releases/tag/v2.1.3 There's no corresponding conda-forge package yet. Maybe some of the...

feat: add pypi-to-conda-name overrides to pyproject parsing

Thanks @tlambert03 for adding the tests! Unfortunately they don't seem to be passing yet.

feat: add pypi-to-conda-name overrides to pyproject parsing

Ah, ya, no pressure. It's always such a pain when tests run locally but not in CI. Good luck and thanks for all your work!

feat: add pypi-to-conda-name overrides to pyproject parsing

At first glance this looks really great! Unfortunately I'm really slammed with work at the moment, so it might be a bit before I can give this a proper look.

feat: add pypi-to-conda-name overrides to pyproject parsing

> not sure I'm following this comment. That class is already there. Are you proposing we remove it and re-add it later? Ah, my bad, I was confused. I thought...

feat: add pypi-to-conda-name overrides to pyproject parsing

@tlambert03, sorry for letting this slip. Do you understand why the tests are failing though?

[pre-commit.ci] pre-commit autoupdate

pre-commit.ci run

[pre-commit.ci] pre-commit autoupdate

pre-commit.ci run

custom pypi repository on the local disk (`file://` urls)

Thanks, it would definitely be great to support this. You have thought much more deeply about this than I have. Ideally we don't implement anything that increases our dependency on...

custom pypi repository on the local disk (`file://` urls)

I don't think it would be problematic to vendor a patched `requests-file` in `conda-lock`, but upstreaming it would be preferable.