Marc Stern comments

Results 153 comments of


                                            Marc Stern

In case no rule id exists, log file name & line number in debug log

Unclean PR, to be replaced by another one

Performance enhancement calling expand_macros()

If I implement this PR, would it be accepted?

Handle capture as tx.1=char in validateByteRange

This allows to know what's the offending character. Very useful in complex configurations with multiple , defined variables, macros, etc.

Handle capture as tx.1=char in validateByteRange

What about limiting it to 9 then? It would be easy: if (capture && count < 10)

Handle capture as tx.1=char in validateByteRange

I adapted the PR

Handle capture as tx.1=char in validateByteRange

Unclean PR, to be replaced by another one

Allow multiple digits in sanitizeMatchedBytes

> Hi @marcstern , > I assume this is meant to address this issue that you raised?: #2472 Correct

Allow multiple digits in sanitizeMatchedBytes

Unclean PR, to be replaced by another one

Regex in setvar variables

Hi @martinhsv, 1. Indeed, some escape sequences could be replaced by posix character classes, but I'm pretty sure we can find some that cannot. 2. Using LUA is only possible...

Regex in setvar variables

Hi @martinhsv , Here is my proposal: 1. replace `if ((*(p + 1) == '\0') || ((*(p + 1) != '\'') && (*(p + 1) != '\\'))) {` by `if...