Marc Stern
Marc Stern
Actually, the problem is more general than Visual C++. We have ``` #ifdef __cplusplus extern "C" { #endif /** The JWE algorithm header attribute name. */ extern const char *CJOSE_HDR_ALG;...
Sounds good overall, just a few remarks: 1. In case of error, we should log the reason and the path 2. We should create a "get_lock" function englobing apr_file_mktemp(), apr_file_name_get()...
acquire_global_lock() prototype should be added in modsecurity.h in case we want ot reuse it elsewhere (or it should be marked as static for now). The #ifdef __SET_MUTEX_PERMS should also move...
Wouldn't it be better to always use long instead of (sometimes) unsigned long? Especially as there are some tests
Remark: all this code is duplicated all over the file and could be enclosed in a function: ``` /* Figure out if we want to include this variable. */ if...
That mechanism is used to oblige the client to read the answer quicker than normal. I don't see any reason to do that in ModSecurity, except maybe in hook_connection_early() when...
I unfortunately have no more info than in my last remark: _I don't see any reason to do that in ModSecurity, except maybe in hook_connection_early() when the client has too...
From what I understand, it allows to close the connection quicker _in case the request wasn't complete_. So, I guess it may be a good idea inside hook_connection_early() where we...
replaced by https://github.com/owasp-modsecurity/ModSecurity/pull/3191
I'll make a PR for this