Marc Stern comments

Results 153 comments of


                                            Marc Stern

Feature Request: Filter out whitespace diffs, including newline changes.

Any chance to get this? That would save my life (and all developers' one wanting to compare branches)

V2/rule remove target by tag/macro

Obsoleted by https://github.com/SpiderLabs/ModSecurity/pull/2964

Problem in retrieving collections from Persistant Storage

Sorry, I didn't get the first notification. The code changed in 4 years and the problem potentially partly disappeared, although it's not totally clear. The problem was that stored collections...

feature request: cache transformed value

What about the SecCacheTransformations directive?

sanitiseMatchedBytes only works with 1 digit parameters

Hello. I don't see any remark. Could this be accepted?

NULL pointer

Actually, it would maybe be safer to perform the checks in construct_single_var(): `if (!msr || !msr->mp || !msr->modsecurity) return NULL;` We should also check msr->modsecurity->msre & msr->msc_rule_mptmp, either in construct_single_var()...

Enhance documentation to discuss database updates

Parts of the DB are never reread from disk, even in case of swapping, etc. Otherwise, a running process could get some data about the new version while still having...

Bug: Premature EOF in JSON leads to status 500 instead of REQBODY_ERROR

Returning 1 instead of rcbe allows more flexibility, as you can decide yourself what to do (ant to log), but put more responsibility on the configurator. I personally prefer this,...

@ipMatch misses IP with multiple values

This is an important bug. Did anyone have a look at it?

ModSecurity not finding SecMarker in phase 2

We should validate the syntax of the parameter in cmd_rule_remove_by_id()