Marco Roth

Results 253 issues of Marco Roth

# Feature Request This is more like a refactoring idea for the `schema.js` file at: https://github.com/stimulusreflex/stimulus_reflex/blob/945428c0aab9f88c5b119f3ae8f8e54893958b53/javascript/schema.js#L18-L29 The current approach uses `Object.defineProperty` to define properties on the exported object so that...

enhancement
help wanted
good first issue

# Type of PR Feature ## Description I had this one sitting around for a while, but thought I'll open this as a draft PR for visibility. This PR allows...

## Expected behavior A migration like this shouldn't add a `Rails/ReversibleMigrationMethodDefinition` offense: ```ruby class SomeMigration < ActiveRecord::Migration[7.1] def self.up # ... end def self.down # ... end end ``` ##...

We should think about dropping support for Rails 5.x and Rails 6.0

## Bug Report ### Describe the bug Thanks to @javid-gulamaliyev, we were able to figure out that in the current version of StimulusReflex you can't use StimulusReflex and the Session...

# Type of PR ## Description Looks like Chris McCord took over the responsibility for maintaining `morphdom` and released `2.7.0`. ## Why should this be added In order to keep...

# Type of PR Bug Fix ## Description In some cases custom operations can get swept away when setting operations multiple times. ## Why should this be added This fixes...

While working on Stimulus LSP I noticed that the `slideover` controller has a duplicate `menu` target. The `dropdown` controller already defines that target and the `slideover` controller is therefore automatically...

Implemented via https://github.com/rubygems/rubygems.org/pull/4034 https://github.com/rubygems/rubygems.org/blob/d630c5ed5cd3d0988f0b3c24971a41b22bba074f/config/routes.rb#L16-L19

Resolves #1055, depends on https://github.com/Shopify/vscode-ruby-lsp/pull/896 ### Motivation ### Implementation ### Automated Tests ### Manual Tests