Marco Roth comments

Results 324 comments of


                                            Marco Roth

Fix language formatting in Github

Hey @ollietb, thanks for opening this! Technically those markers are to highlight the relevant code-lines in the docs. Though breaking the code formatting on GitHub is not nice. ![Screenshot 2022-08-11...

`useTransition`: DOMException: Failed to execute 'add' on 'DOMTokenList': the token provided must not be empty.

Hey @xwenc I'm sorry you are experiencing some unexpected behavior. You might want to upgrade `stimulus-use` to `0.24.0-2` to see if that fixes your issue. There is #115 and a...

`useTransition`: out of sync when used multiple times quickly

Is there any chance we can improve this in Stimulus Use as well, so that all people can benefit from it?

Introduce useRequestIdleCallback optimization hook

Hey @gremo, thanks for opening this! This looks interesting and is also the first time I have heard of this API! I don't see a reason why we wouldn't/shouldn't introduce...

Introduce useRequestIdleCallback optimization hook

Thanks, let's continue the discussion in the PR

`useIdle`: Typescript error: argument of type 'this' is not assignable to parameter of type "IdleComposableController"

Hey @gremo, thanks for reporting this! Are you using this with Stimulus 3.1, right? I think it might have to do with new the support for extending Stimulus controllers within...

Introduce `useBreakpoints` mixin

Thank you @romaricpascal, I appreciate the detailed response! I think the best way is if I answer to each list item individually: * That's right. I thought about throttling the...

Introduce `useBreakpoints` mixin

I just put up #128 which should cover the use-cases @romaricpascal has pointed out ☺️

`useHotkeys`: does not pass HotkeysEvent as argument to a handler.

@pySilver do you have a hunch on how we could fix it? I'm not too familiar with the `useHotkeys()` yet

`useHotkeys`: does not pass HotkeysEvent as argument to a handler.

/cc @julianrubisch