ruby-lsp icon indicating copy to clipboard operation
ruby-lsp copied to clipboard

Add ERB Support

Open marcoroth opened this issue 2 years ago • 4 comments

Resolves #1055, depends on https://github.com/Shopify/vscode-ruby-lsp/pull/896

Motivation

Implementation

Automated Tests

Manual Tests

marcoroth avatar Nov 13 '23 23:11 marcoroth

This pull request is being marked as stale because there was no activity in the last 2 months

github-actions[bot] avatar Jan 29 '24 12:01 github-actions[bot]

This pull request is being marked as stale because there was no activity in the last 2 months

github-actions[bot] avatar Apr 08 '24 12:04 github-actions[bot]

Hey @marcoroth! What's the status of this one? I'm really wishing that Ruby LSP supported ERB Lint.

natematykiewicz avatar Apr 14 '24 03:04 natematykiewicz

We are currently missing the right tools to fully provide really useful support for ERB. This PR only adds super basic support.

I guess the question is if we want to finish up and merge the most minimalistic ERB support (which is implemented here) or if we should wait until we can build the needed tools.

I do have some ideas for the tooling and needed infrastructure, but it needs more coordination and work, which is out of scope for this PR.

marcoroth avatar Apr 14 '24 03:04 marcoroth

This pull request is being marked as stale because there was no activity in the last 2 months

github-actions[bot] avatar Jun 13 '24 12:06 github-actions[bot]

Just for the record, I'm working on the infrastructure tooling right now which is needed to support ERB. I will open a new PR once it's ready and properly useable/useful.

The current version in this PR is very minimalistic and probably not very useful in real scenarios.

marcoroth avatar Jun 27 '24 22:06 marcoroth

cc @st0012 since you were hacking on this too.

vinistock avatar Jun 28 '24 12:06 vinistock

It might make sense to catch up and compare notes, thanks @vinistock!

@st0012 I'm going to reach out to see if we can combine efforts.

marcoroth avatar Jun 28 '24 12:06 marcoroth

@marcoroth 👋 just opened my PR: https://github.com/Shopify/ruby-lsp/pull/2235 It allows Ruby LSP to start processing erb files and provide existing code navigation features there too. Several features like formatting or linting are still not working tho.

st0012 avatar Jun 28 '24 15:06 st0012