Marco Roth

Results 324 comments of Marco Roth

I'm afraid this one needs quite some rework after #41. Sorry about that!

Thanks for reporting @PedroAugustoRamalhoDuarte! I'm going to take a look 🙌🏼

Oh, I never came across devdocs. Are they also using docsets?

@ttilberg improved this a bit in #44, but I think there are still some thing we can improve, like: - the character escaping mentioned in #44 - code highlighting in...

I think either would work. But we probably would need to do some research to figure out what people would want/expect from such a feature. I like the simplicity of...

Some ideas ![CleanShot 2023-08-03 at 22 59 34](https://github.com/marcoroth/gem.sh/assets/6411752/c3760658-4a22-415a-b255-6f46e3582f54) ![CleanShot 2023-08-03 at 22 59 46](https://github.com/marcoroth/gem.sh/assets/6411752/18733b17-4043-4fef-bc61-6c9b705fc1a4)

I guess this only really fixes the symptoms, but I wonder why they show up multiple times in the first place. It seems like there's another issue somewhere deeper in...

This might still be worthwhile to add, nonetheless

The issue is here: https://github.com/marcoroth/stimulus-lsp/blob/93fdd53e5b41032a9f242b05460e89105c9050d7/server/src/diagnostics.ts#L324 Since the linked issue is importing two exports we also have two "import declarations" in the array, one for each import, thus resulting in the...

Oh interesting, thanks for the investigation @nachiket87! After thinking about this a bit more, it feels like this diagnostic should anyway be part of the Stimulus Parser itself and not...