Marc Khouzam

> I think that if Cobra is to support colours it should respect `NO_COLOR` for itself and for any program that is using Cobra. > If someone would like to...

What shall we do with this colour PR? Reading the comment from @catthehacker, I don't know if this change will work on Windows, @JulesDT do you have the ability to...

I think this makes sense but needs a proper review. Re-opening.

Thanks @donggangcj. When I tried this fix with helm, it didn't address the problem described in #1156. Could you provide a test program that shows the problem before the PR,...

> I read the source code of cli which is using cobra but it doesn't appear this problem. Actually, it looks like they hack their way around this problem: https://github.com/cli/cli/blob/1ddb4d76a750748012c91204740d49991ad2f968/cmd/gh/main.go#L59...

> Could/should this change take into account ValidArgsFunction? Please see #1298

IIUC this PR gives the option to turn off default completions suggestions all the time. Default completions are the list of file in the current directory. I think this ability...

With Cobra 1.0, it is now possible to disable file completion on a per command basis. Please see `ShellCompDirectiveNoFileComp` in this section of the documentation: https://github.com/spf13/cobra/blob/master/bash_completions.md#1-custom-completions-of-nouns-written-in-go I believe this PR...

> With Cobra 1.0, it is now possible to disable file completion on a per command basis. Please see `ShellCompDirectiveNoFileComp` in this section of the documentation: https://github.com/spf13/cobra/blob/master/bash_completions.md#1-custom-completions-of-nouns-written-in-go > > I...

I agree with @johnSchnake on this. Furthermore, the Cobra project is already strained so it would be difficult to have to maintain support for other flag forms.