cobra icon indicating copy to clipboard operation
cobra copied to clipboard

Published 20 hours ago • verified publisher icon spf13

Add flag that gives the ability to disable bash default completion

Open geoand opened this issue 6 years ago • 6 comments

-o default supplied to complete forces bash to provide the default suggestions when the custom bash completion scripts do not provide any values (as is described here). This is a sensible default, but in a of lot does not make sense and can potentially confuse uses of applications using this feature.

To remedy the situation a flag is provided that can turn of the bash default generation when enabled

geoand avatar Oct 04 '18 15:10 geoand

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 04 '18 15:10 CLAassistant

I'm not really sure what to make of the test failures, I can't really tell if they are related or not... They appear to only happen with old go versions...

geoand avatar Oct 04 '18 15:10 geoand

@eparis Could you please have a look?

Thank you

geoand avatar Oct 04 '18 15:10 geoand

IIUC this PR gives the option to turn off default completions suggestions all the time. Default completions are the list of file in the current directory.

I think this ability would be nice but I think it should be on a case by case basis. Showing local files is wrong for some commands, but for others it is correct and important.

I've posted a PR that allows to write custom completions in Go (https://github.com/spf13/cobra/pull/1035) and it provides the ability to turn off default completions on a per-command basis: https://github.com/spf13/cobra/pull/1035/files#diff-c07279f68bfb9c503f680286cc72dd88R155

marckhouzam avatar Feb 16 '20 23:02 marckhouzam

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar Apr 17 '20 00:04 github-actions[bot]

With Cobra 1.0, it is now possible to disable file completion on a per command basis. Please see ShellCompDirectiveNoFileComp in this section of the documentation: https://github.com/spf13/cobra/blob/master/bash_completions.md#1-custom-completions-of-nouns-written-in-go

I believe this PR can therefore be closed.

marckhouzam avatar Apr 26 '20 23:04 marckhouzam

With Cobra 1.0, it is now possible to disable file completion on a per command basis. Please see ShellCompDirectiveNoFileComp in this section of the documentation: https://github.com/spf13/cobra/blob/master/bash_completions.md#1-custom-completions-of-nouns-written-in-go

I believe this PR can therefore be closed.

marckhouzam avatar Aug 14 '22 13:08 marckhouzam