cobra icon indicating copy to clipboard operation
cobra copied to clipboard

Improving the "required flag(s) "%s" not set" error message by not printing "(s)" if a single required flag is missing

Open nestoroprysk opened this issue 4 years ago • 6 comments

Improving the "required flag(s) "%s" not set" error message by not printing "(s)" if a single required flag is missing.

If a single flag is missing, the error message is of the form "required flag "%s" not set".

Otherwise, the error message remains unchanged.

nestoroprysk avatar Sep 03 '20 14:09 nestoroprysk

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 03 '20 14:09 CLAassistant

signed in the agreement

nestoroprysk avatar Sep 03 '20 16:09 nestoroprysk

@nestoroprysk please add a description to your PR. Add details that will help maintainers get on the same page as you about this change.

jharshman avatar Oct 04 '20 01:10 jharshman

@jharshman updated the description and resolved conflicts

nestoroprysk avatar Oct 04 '20 09:10 nestoroprysk

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar Dec 04 '20 00:12 github-actions[bot]

I think this makes sense but needs a proper review. Re-opening.

marckhouzam avatar Mar 30 '22 00:03 marckhouzam