Marc R. Hoffmann

Results 355 comments of Marc R. Hoffmann

Thanks @muminc for adding the same option to Ant and CLI! Do you have an idea how the new option can actually be tested in our integration test suites?

@muminc I had two explicit test cases for the append flag in mind (true and false). I implemented it for the dump command: https://gist.github.com/marchof/d18d3d88460467964a83c4e47f85e024 (I can't push to your PR...

This looks like a major braking change as probably nobody supplies our DTD. @Godin Do you really think this optimization is worth it?

I like the idea of inlining the DTD! Also we can improve our DTD to define default values. Then existing parsers shouldn't be affected.

@Godin Before we add new validation test project for Java 17 what about my proposed validation test cleanups up to Java 16 in #1165? Maybe we merge this first?

@Godin Any chance that you find some time to review this?

@danbelov Thanks for your feedback and sorry for the delayed answer. I tried to address your issues: 1. Added an new `CONTRIBUTING.md`and a link to `README.md`. Currently our documentation is...

You can specify any precision for the check goal, while the report percentage column always display percentage with 2 digit precision ("98%"). The issue here is probably more with rounding:...

To make it customizable we might add format specs to #382. Users might want to also configure decimals for percentage columns.