Marc R. Hoffmann
Marc R. Hoffmann
Can you please show a source example how the annotation should be used?
Die due the ambiguity that @Godin identified we will probably drop this.
@maxkan Well, you have a look here: https://github.com/jacoco/jacoco/blob/a9ce74eb6986be5121c6876c9f37018c85a27263/org.jacoco.doc/pom.xml#L131 Maybe you better help @fmarot to find a working solution?
@Godin There is one thing I don't like about this PR: When the DTD is inlined there is no way to denote a schema public ID. So we're loosing a...
@Godin I think at least the report version is mandatory: So integrators can test compatibility with it. Otherwise integrators would need to update their mapping (JaCoCo version -> report version)...
Thanks for this detailed report! I'll try to debug what makes the test that slow.
Did a quick check in GitPod 🙀: https://github.com/assertj/assertj-core/commit/ad51a031cbf67b243cd0823effe37b8642b1774e -> 02:10 min https://github.com/assertj/assertj-core/commit/41179e555463021737468f71785ecca5aac152bb -> 14:14 min
A quick profiling showed that most of the time is spent in applying the filter regex for the filter: If I replace **/*hamcrest*/** with *hamcrest* the build time is down...
@joel-costigliola Thanks for the feedback! I'll keep this open because I want to investigate the root cause.
@Godin Unfortunately this gives creates a static dependency from the instrumented classes to the coverage library -- which does not work in most containers. JaCoCo uses different strategies to communicate...