Marc R. Hoffmann
Marc R. Hoffmann
@Godin Scanning a larger repo (Thanks @p45q!) found the following exception: java.lang.NullPointerException at org.jacoco.core.internal.analysis.filter.FinallyFilter.isSame(FinallyFilter.java:93) at org.jacoco.core.internal.analysis.filter.FinallyFilter.filter(FinallyFilter.java:45) at org.jacoco.core.internal.analysis.filter.FinallyFilter.filter(FinallyFilter.java:30) at org.jacoco.core.internal.analysis.MethodAnalyzer.accept(MethodAnalyzer.java:130) at org.jacoco.core.internal.flow.ClassProbesAdapter$2.visitEnd(ClassProbesAdapter.java:89) at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1036) at org.objectweb.asm.ClassReader.accept(ClassReader.java:708) at org.objectweb.asm.ClassReader.accept(ClassReader.java:521) at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:111)...
@Godin BTW, the command line tool was helpful to run this test in a docker container directly on the repo server :wink: (I have a local branch rebased on your...
@Godin Re colt: The corresponding source îs probably [here](https://dst.lbl.gov/ACSSoftware/colt/colt-download/releases/colt-1.0.3.zip).
@Godin I wouldn't consider or test functional correctness for compiler versions < 1.5. But our code should not throw exceptions on any valid class file supplied. As a side note...
@Godin Another finding on the "big repo" by @p45q: java.lang.IllegalStateException at org.jacoco.core.internal.flow.Instruction.setPredecessor(Instruction.java:81) at org.jacoco.core.internal.analysis.MethodAnalyzer.visitEnd(MethodAnalyzer.java:371) at org.jacoco.core.internal.analysis.ClassAnalyzer$1.visitEnd(ClassAnalyzer.java:71) at org.objectweb.asm.MethodVisitor.visitEnd(MethodVisitor.java:878) at org.jacoco.core.internal.analysis.MethodAnalyzer.accept(MethodAnalyzer.java:142) at org.jacoco.core.internal.flow.ClassProbesAdapter$2.visitEnd(ClassProbesAdapter.java:89) at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1036) at org.objectweb.asm.ClassReader.accept(ClassReader.java:708) at org.objectweb.asm.ClassReader.accept(ClassReader.java:521) at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:111)...
@Godin That's why I was also considering opening a separate issue. If this is a bigger think we should move the assertion and fix into a separate PR.
Not quite whether the proposed solution will work for our existing use cases. If we create our own annotation this means the code base needs a dependency on that library...
@XenoAmess It is not a question whether it can be technically implemented. It is a question how to maintain it. Filtering is quite a complex topic and config options add...
Hi @hgschmie thanks for your contribution! Can you please elaborate what problem in what scenario is solved with this?
Hi @APshenkin, the CLI is designed for simple ad-hoc use cases. The check tasks/goals have complex configuration options I don't see at the command line.