Marcelo Gornstein

Results 51 comments of Marcelo Gornstein

hi! please make sure you only include the needed change, and that it's unit tested. please don't include any identation changes, and try to follow the style of the original...

sorry that i closed it by mistake. feel free to rebase and push force for this same pull

mmm i don't like this idea.. have you tried using Node::prePromptMessagesNotInterruptable( ) ?

I should have mentioned why I'm not so much into this change: Prompts should not change in their definition (essentially). And this adds complexity to the api (and complexity when...

I understand your point. On one hand, I don't see why you can't just validate the input and play a message like "invalid option". In your example, where you ask...

Please, Jacob, I'm very happy (and actually enjoy) to discuss these matters, it's all about making things better for both devs and users. I'll leave this one open, and play...

@d4rkstar hey bruno :) question: what happened with this file? src/mg/PAGI/Node/NodeController.php? i mean, doesn't look like it changed, can we remove it from the pr?

Hi! Can you add a unit test for this?

Sure, I'd be glad to :) To be honest, I haven't had a great need for this, so I haven't put that much thought into it. What would you expect...

Hello :) I have to admit that I haven't used v12 myself, so I don't fully understand the changes involved. Could you elaborate a bit more on what would be...