Marcel Martin
Marcel Martin
Sorry, but I missed your question. Is this still relevant?
Hi, > My reads were generated using the Illumina DNA PCR-Free Prep kit, which, according [Illumina's adapter sequence documentation](https://support-docs.illumina.com/SHARE/AdapterSequences/Content/SHARE/AdapterSeq/Nextera/SequencesNextera_Illumina.htm), uses the following two adapter sequences in both the forward and...
Awesome! Let’s get this into shape so it can be merged. I’m looking at the failing tests at the moment. When I run `tests/run.sh`, I get: ``` Failure running 'diff...
> You are right, we do report chains that cover the same region on a reference. > > I fixed it, by preventing reporting chains with an already used anchor....
I have now rebased this PR on top of main and cleaned up the commit history as much as I could. I also ran all the tests for each commit...
I think this deserves to be merged now. The chaining code as it is here is what we are running in our current benchmarks, so it makes sense to mark...
I assume you also did not use `xopen` as a context manager. If so: You cannot rely on `close()` being called for you when the object is garbage collected (that...
There’s no guarantee that `__del__` is called, even within a function. It’s not like in C/C++/Rust etc. where a destructor is run as soon as the variable gets out of...
> An alternative quick fix would be to add a `__del__()` method (sorry @marcelm) to the `FileWriter` class that closes the object when it goes out of scope, which might...
How did you trigger this? Would be good to have a test as well.