Marc Alff

Results 165 comments of Marc Alff

Thanks @jack-berg for the clarifications. The spec wording is (emphasis mine): > For callback functions registered **after** an asynchronous instrument is created, the API is required to support a mechanism...

Keeping this issue open, as a proxy, so it gets tracked in cpp milestones. Doc to be delivered in opentelemetry.io, see https://github.com/open-telemetry/opentelemetry-cpp/issues/1589

The first commit fails 18 checks, which is actually **good**. This commit only contains the unit test, which fails, showing that the unit test logic is working.

See `file api/include/opentelemetry/common/macros.h` for the technical solution Status as of Sept 7: - fix for gcc and clang works for linux and macos. - the unit test added, singleton_test, builds,...

@owent > Sorry, but I found `__declspec(selectany)` doesn't work when linking the `.lib` of a shared library on Windows, and I didn't find a way to let cmake link the...

Status: This PR, 1595, is kept open to continue investigation for windows. The fix for gcc and clang, which is working, is to be merged in PR #1604.

Added the help wanted tag. Not a windows expert, so anyone with more knowledge is welcome to investigate, either using this patch as a base (if it helps) or proposing...

To discuss in the SIG meeting. @svrnm , @lalitb , some questions here: I would like to understand the expected workflow, from a developer perspective. opentelemetry-cpp is a repository, with...

> * People reading the docs can (and will) report issues to the opentelemetry.io repo, so we have to push them down to the cpp project as needed Thanks @svrnm...

Doc team: @svrnm @cartermp @open-telemetry/docs-maintainers Cpp team: @lalitb @owent @esigo @ThomsonTan @open-telemetry/cpp-maintainers cc: @open-telemetry/docs-approvers cc: @open-telemetry/cpp-approvers We discussed documentation in C++ SIG meeting on 2022-09-07, please see the proposal below,...