Marc Alff
Marc Alff
@open-telemetry/specs-approvers Some update on this issue, about metrics. opentelemetry-cpp now provide a way to remove a callback for an async instrument. While this resolves the immediate concern, crashes that happened...
Related: * https://github.com/open-telemetry/opentelemetry-cpp/pull/2455
@hdost Please note that I used `-z`, lowercase, not `-Z`, uppercase, for https://github.com/open-telemetry/opentelemetry-cpp/pull/2455. Not sure which one you need to generate proto files.
Reproducible test case: ``` // Build with: // g++-12 -I/opt/benchmark-1.8.3/include/ foo.cc // // Fails: // // In file included from foo.cc:5: // /opt/benchmark-1.8.3/include/benchmark/benchmark.h: In instantiation of ‘typename std::enable_if sizeof (Tp*)))>::type...
@sakshi-1505 Thanks for volunteering, and welcome. First step is to investigate the C++ tooling available, and decide which tool to use. Second step will be to implement CI scripts to...
Please clarify: * which compiler is used, including the exact compiler version * which --std=c++ standard version is used (C++11/14/17/20/23) The relevant opentelemetry-cpp code is: ``` #if !defined(OPENTELEMETRY_LIKELY_IF) && defined(__cplusplus)...
> I am building envoy-contrib with this option `--config=rbe-toolchain-clang-libc++`. Ok, but this does not tell us anything about the compiler version, and the C++ standard used.
@shiponcs I see this issue got reopened. PR #2580 should resolve the issue with C++20, what are the remaining problems at this point ?
Thanks for the issue. I experienced the same problem myself, having to implement a `TextMapCarrier` with no op and assert(false) for one interface, implementing only the other one. Not sure...
From the [spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/context/api-propagators.md): " Injectors and Extractors as Separate Interfaces Languages can choose to implement a Propagator type as a single object exposing Inject and Extract methods, or they can...