Marc Alff
Marc Alff
@perhapsmaple Also, please indicate how testing was done. For OTLP HTTP, a possibility is to change locally `functional/otlp/func_http_main.cc` to use gzip compression, and run tests against an opentelemetry-collector.
@perhapsmaple This PR was discussed in the maintainers meeting today. To avoid disruption in makefiles and build scripts, we do need to define a feature flag. Please implement the following:...
@perhapsmaple See previous comment for `ci/do_ci.sh`.
@perhapsmaple Thanks for the CMake fixes in CI. About bazel, you are correct this _should_ also include a feature flag in the bazel build. We lack experience with bazel as...
Approving review, and adding a temporary do-not-merge flag (don't worry), because we are making a 1.14.2 release right now.
@perhapsmaple No rush, thanks for all the work done already. I am merging this PR now then, the optimization can be done separately (and at your own pace).
Thanks for the PR. Not a full review, but this looks good based on a first read. Please sign the EasyCLA to pass the CI checks.
> > Is it possible to add a test case to reproduce the issue and verify the fix? > > Good point. But this problem is hard to reproduce. I...
LGTM and approved, waiting for @owent to confirm since he had comments earlier.