Marc Alff

Results 323 comments of Marc Alff

To revisit once spec is merged: * https://github.com/open-telemetry/opentelemetry-specification/pull/4020

Spec is now merged. Adding a `Enabled()` method in the `API` is an `ABI` breaking change, to implement in `ABI_VERSION_2` only.

See related: * https://github.com/open-telemetry/opentelemetry-specification/pull/4063

Note that this issue proposes to go strait to removal of TLS 1.0 and 1.1, without announcing deprecation in opentelemetry-cpp. Per: https://en.wikipedia.org/wiki/Transport_Layer_Security#History_and_development TLS 1.0 and TLS 1.1 have been deprecated...

@msiddhu Thanks for the separate confirmation. Do you have more details, like a call stack ? Saying "it crashes for me too" gives us next to nothing to work with.

The part which is really dubious is: * a bug report about OTLP HTTP * a call stack pointing to `libopentelemetry_exporter_otlp_grpc.so` Is this about OTLP HTTP or OLTP GRPC ?...

Please review. I suggest to wait at one or two weeks for possible comments on this (the removal issue is pinned), before merging to main.

> Should this PR be included in the coming minor build (like 1.7.0) instead of patch build? Current release is 1.16.0, so next patch build will be 1.16.1 This removal...

> @marcalff can you link each upstream issue with the relevant issue in opentelemetry-cpp (if they exist) Done for the first 2. For the problem with the collector -> prometheus...

For reference, from the DEPRECATED.md file published in 1.16.0: --- ### SDK ProviderFactory cleanup #### Announcement (SDK ProviderFactory cleanup) * Version: 1.15.0 * Date: 2024-06-03 * PR: [API/SDK] Provider cleanup...