Marc Alff
Marc Alff
> And the in the callback function, we have the line: opentelemetry::nostd::get(observer_result)->Observe(value_, labels); There is no such thing as a `opentelemetry::nostd::shared_ptr` `ObserverResultT` is a template, and it is used with:...
Thanks for the report. Using opentelemetry-1.16.0 with `WITH_ASYNC_EXPORT_PREVIEW=OFF`: can not reproduce Using opentelemetry-1.16.0 with `WITH_ASYNC_EXPORT_PREVIEW=ON`: reproduced The example code `example_otlp_http` invokes `ForceFlush()`, which is supposed to wait for spans to...
Thanks for the report. Per file `api/include/opentelemetry/nostd/string_view.h`, the following are missing and probably could help: * a `nostd::string_view()` constructor that takes a `std::string_view` as input * a `std::string_view` operator, to...
Marking as blocking, because this PR is likely to cause merge conflicts with the clang-tidy cleanup: * #2990 so it is very desirable to get this merged soon. Also, merging...
Thanks for the report. The nginx module is part of the https://github.com/open-telemetry/opentelemetry-cpp-contrib repository, not https://github.com/open-telemetry/opentelemetry-cpp. Migrating the issue to contrib.
Root cause: ``` static ngx_int_t ngx_http_opentelemetry_init(ngx_conf_t *cf) { ... ngx_writeError(cf->cycle->log, __func__, "Starting Opentelemetry Module init"); ``` The issue is not with `NginxModuleTraceAsError`, but more like `ngx_writeError()` used instead of `ngx_writeTrace()`.
Related: * https://github.com/open-telemetry/opentelemetry-cpp-contrib/issues/401
Looks like there is no CI in the repo. Did not test locally, can't even get cmake to build.
Closing, no longer relevant now that opentelemetry-cpp 1.19 is used.
Thanks for the report. PR are always welcome.