John Doe issues

Results 25 issues of


                                            John Doe

little fix for 'mulsh'

https://github.com/marakew/ida-xtensa/commit/846d26ea7602d33945ccecfc6a9e626b23de7a20

little fix for ida 7.5

https://github.com/marakew/ida-xtensa/commit/3512da5d5876934002e6d3f71f143eb7bc98caae

allow unpack msi if some cab are missing

``` --- a/src/LessMsi.Core/Msi/Wixtracts.cs +++ b/src/LessMsi.Core/Msi/Wixtracts.cs @@ -504,7 +504,7 @@ namespace LessMsi.Msi Path originalCabFile = Path.Combine(msi.Parent, cabSourceName); if (!originalCabFile.Exists) { - throw ExternalCabNotFoundException.CreateFromCabPath(cabSourceName, msi.Parent.FullPathString); + continue; //throw ExternalCabNotFoundException.CreateFromCabPath(cabSourceName, msi.Parent.FullPathString); } FileSystem.Copy(originalCabFile,...

enhancement

help wanted

good first issue

chacha20 poly1305

how about add unsupported ChaCha20 Poly1305 ? I dont known how to check build chacha20_poly1305 with new openssl 1.1.0 because travis use old openssl 1.0.1

Condition 'sizeCol()>1' is always true

https://github.com/Haivision/srt/blob/e8b713e954345291e8d6e2314d1e5094a6a14179/srtcore/fec.cpp#L456

Parameter 'xxx' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.

https://github.com/Haivision/srt/blob/e8b713e954345291e8d6e2314d1e5094a6a14179/srtcore/congctl.h#L56 https://github.com/Haivision/srt/blob/e8b713e954345291e8d6e2314d1e5094a6a14179/srtcore/common.cpp#L460 https://github.com/Haivision/srt/blob/e8b713e954345291e8d6e2314d1e5094a6a14179/srtcore/api.cpp#L4474 https://github.com/Haivision/srt/blob/e8b713e954345291e8d6e2314d1e5094a6a14179/srtcore/packetfilter.cpp#L29 https://github.com/Haivision/srt/blob/e8b713e954345291e8d6e2314d1e5094a6a14179/srtcore/packetfilter.cpp#L46

Condition '2==sek_cnt' is always true

https://github.com/Haivision/srt/blob/e8b713e954345291e8d6e2314d1e5094a6a14179/haicrypt/hcrypt_ctx_rx.c#L192

Either the condition 'NULL==crypto' is redundant or there is possible null pointer dereference: crypto.

https://github.com/Haivision/srt/blob/e8b713e954345291e8d6e2314d1e5094a6a14179/haicrypt/hcrypt_tx.c#L58 https://github.com/Haivision/srt/blob/e8b713e954345291e8d6e2314d1e5094a6a14179/haicrypt/hcrypt_tx.c#L86 https://github.com/Haivision/srt/blob/e8b713e954345291e8d6e2314d1e5094a6a14179/haicrypt/hcrypt_tx.c#L100 https://github.com/Haivision/srt/blob/e8b713e954345291e8d6e2314d1e5094a6a14179/haicrypt/hcrypt_tx.c#L133

DataKind error always

result of get_dataKind got error https://github.com/wbenny/pdbex/blob/master/Source/PDB.cpp#L621 because it should call from another context as example to here https://github.com/wbenny/pdbex/blob/master/Source/PDB.cpp#L863 and call by DiaChildSymbol-> and move DataKind from SYMBOL to SYMBOL_UDT_FIELD

incorrect condition for check result produce crash

if we have error for load dll at here https://github.com/wbenny/pdbex/blob/master/Source/PDB.cpp#L77 we are skip this condition https://github.com/wbenny/pdbex/blob/master/Source/PDB.cpp#L115 FAILED check for < 0 then we return FALSE so we crash when continue...