lessmsi icon indicating copy to clipboard operation
lessmsi copied to clipboard

allow unpack msi if some cab are missing

Open marakew opened this issue 2 years ago • 3 comments

--- a/src/LessMsi.Core/Msi/Wixtracts.cs
+++ b/src/LessMsi.Core/Msi/Wixtracts.cs
@@ -504,7 +504,7 @@ namespace LessMsi.Msi
 								Path originalCabFile = Path.Combine(msi.Parent, cabSourceName);
                                 if (!originalCabFile.Exists)
                                 {
-                                    throw ExternalCabNotFoundException.CreateFromCabPath(cabSourceName, msi.Parent.FullPathString);
+                                    continue; //throw ExternalCabNotFoundException.CreateFromCabPath(cabSourceName, msi.Parent.FullPathString);
                                 }
 								FileSystem.Copy(originalCabFile, localCabFile);
 							}

marakew avatar May 29 '22 10:05 marakew

Thanks @marakew! Would you be interested in submitting a pull request for this? I'm open to accepting this if we can make it optional. This is used as a shell script for many users and ignoring such failures may cause a problem for them. I could look into it and advise how to make it optional if that helps.

Or if you're looking for someone else to take it from here (😢😉) let us know and we can see if someone else with a similar need would pick it up...

activescott avatar May 29 '22 14:05 activescott

too small changes for pull request iam patch for self and all works and just share my changes

marakew avatar May 29 '22 16:05 marakew

Fair enough. Thanks for sharing!

activescott avatar May 29 '22 22:05 activescott