Marek Fišera

Results 162 comments of Marek Fišera

@radekdoulik Do you know what changes in emsdk for 8.0 that `EXPORT_ES6` now produces a warning?

Looking at offended builds, binlog always correctly contains `PrintRuntimePackPath` target and the message. Only the text output in log is missing it, including the standard dotnet build summary > Build...

There is a library for reading binlog https://www.nuget.org/packages/MSBuild.StructuredLogger. Maybe if we don't get "Build finished" message from the build process output, we can try to read all messages from binlog

In debug build it passed locally. It might be just that the message we are expecting doesn't get outputed in release configuration. Happens just in release config. The message is...

As kg mentioned offline, it might be that not a single method was optimized in release config

I'm not able to reproduce it locally. It doesn't seem related to fingerprinting. The message comes from xunit orchestration. It looks like a race condition.

@mkhamoyan Can you please look into this one? It's quite low priority (if don't start happening more often, but it doesn't seem so far). The exception comes from `ToolCommand` https://github.com/dotnet/runtime/blob/main/src/mono/wasm/Wasm.Build.Tests/Common/ToolCommand.cs#L110...

If we don't remove the built-in HotReload, we need to make these APIs as public. They were added in https://github.com/dotnet/aspnetcore/pull/60030. The former `ApplyHotReloadDelta` (which is public in .NET < 10)...