mwish

Results 253 comments of mwish
trafficstars

I just check that there're few common constant used in `encoding.cc`, so maybe spliting them is not hard. But I'm not sure about this. Current code is also ok to...

You can type "take" to take the issue, and create a pull request named "GH-40154: [C++][Parquet] ..." when you finished @changkhothuychung

https://github.com/apache/parquet-format/pull/196#discussion_r1237381221 @alamb @tustvold Hi, I wonder for PageIndex pruning in Rust implementions, would it matter for adding `[-inf, +inf]` as min-max for all nan and null pages? Would it harm...

> Currently the arrow-rs implementation uses the totalOrder predicate as defined by the IEEE 754 (2008 revision) floating point standard to order floats, this can be very efficiently implemented using...

I think we already have type-defined order, and already exclude +inf and -inf. And not when if a page is all `NaN`, the page would be excluded

Okay, `[-NaN, +NaN]` as min-max would be ignored in C++ Statistics. I'm ok for these solutions.

The idea looks ok. I've check arrow parquet's reader implemention. For statistics: 1. If `ColumnOrder` is TypeDefinedOrder, uses `min_value` and `max_value`. But when it find it's a `-Nan, +Nan` pair,...

https://github.com/apache/kvrocks/pull/2298#issuecomment-2105726276 I've meet this issue in rocksdb, sigh...Maybe we should shift to a new version later?

Will merge in 1-days if no negative comments

I'm trying to implement this. During my impl, I found a problem that: 1. Get random set size 2. Get all indices, counting the random fetching indices 3. Traverse the...