Marc Nuri

Results 710 comments of Marc Nuri

Internal reference: [protean-dev] Philosophy around healthchecks - https://docs.google.com/document/d/11L8grYyPCNcHjcoXFo4tZomUG74bQ_JsWJOMmgyWxjQ/edit#

Considering we haven't released 1.9.0 yet, we might want to refactor + redocument what was done in #1541 (#1473). As suggested in https://github.com/eclipse/jkube/issues/1473#issuecomment-1109550057, #1473 looks like a duplicate of this...

### Eclipse JKube [CI Report](https://github.com/jkubeio/ci) Started new GH workflow run for https://github.com/eclipse/jkube/pull/1544 (_2022-10-05T11:31:44Z_) :gear: [JKube E2E Tests (3189315970)](https://github.com/jkubeio/ci/actions/runs/3189315970) - :heavy_check_mark: [Bootstrap CI test run (#1544)](https://github.com/jkubeio/ci/actions/runs/3189315970/jobs/5202982986) - :heavy_check_mark: [K8S v1.12.0 dockerfile...

### Eclipse JKube [CI Report](https://github.com/jkubeio/ci) Started new GH workflow run for https://github.com/eclipse/jkube/pull/1428 (_2022-04-07T01:06:58Z_) :gear: [JKube E2E Tests (2105935508)](https://github.com/jkubeio/ci/actions/runs/2105935508) - :heavy_check_mark: [Bootstrap CI test run (#1428)](https://github.com/jkubeio/ci/runs/5860680652?check_suite_focus=true) - :heavy_check_mark: [K8S v1.12.0 dockerfile...

Hi @MMajd, your PR has change requests, please address them.

### Eclipse JKube [CI Report](https://github.com/jkubeio/ci) Started new GH workflow run for https://github.com/eclipse/jkube/pull/1617 (_2022-08-13T13:24:50Z_) :gear: [JKube E2E Tests (2852074901)](https://github.com/jkubeio/ci/actions/runs/2852074901) - :heavy_check_mark: [Bootstrap CI test run (#1617)](https://github.com/jkubeio/ci/runs/7819419962?check_suite_focus=true) - :heavy_check_mark: [K8S v1.12.0 dockerfile...

### Eclipse JKube [CI Report](https://github.com/jkubeio/ci) Started new GH workflow run for https://github.com/eclipse/jkube/pull/1661 (_2022-08-23T12:25:52Z_) :gear: [JKube E2E Tests (2911361442)](https://github.com/jkubeio/ci/actions/runs/2911361442) - :heavy_check_mark: [Bootstrap CI test run (#1661)](https://github.com/jkubeio/ci/runs/7972739688?check_suite_focus=true) - :heavy_check_mark: [K8S v1.12.0 dockerfile...

I left this one open because the 3rd point of the AC (Assertions should be replaced by AssertJ) was not addressed

### Eclipse JKube [CI Report](https://github.com/jkubeio/ci) Started new GH workflow run for https://github.com/eclipse/jkube/pull/1525 (_2022-08-25T11:15:08Z_) :gear: [JKube E2E Tests (2925965970)](https://github.com/jkubeio/ci/actions/runs/2925965970) - :heavy_check_mark: [Bootstrap CI test run (#1525)](https://github.com/jkubeio/ci/runs/8014229742?check_suite_focus=true) - :heavy_check_mark: [K8S v1.12.0 dockerfile...

Let's create an interface so we don't have to rely on duck types and reflection