jkube icon indicating copy to clipboard operation
jkube copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-jkube

(jkube-kit/config/image/) : Migrate tests from JMockit to Mockito

Open rohanKanojia opened this issue 3 years ago • 4 comments

Component

JKube Kit

Task description

Description

Child of https://github.com/eclipse/jkube/issues/857

Migrate the following tests to use Mockito instead of JMockit:

  • ImageConfigurationTest
  • BuildConfigurationTest

Expected Behavior

All tests in the abovementioned need to be migrated to mockito. All references to jmockit should be removed or replaced with Mockito equivalents.

Acceptance Criteria

  • [x] tests should be migrated to mockito
  • [x] Dependency org.jmockit:jmockit should be removed from pom.xml
  • [ ] Assertions should be replaced by AssertJ
  • [ ] Tests should be evaluated and refactored if applicable (optional)

rohanKanojia avatar Jun 14 '22 12:06 rohanKanojia

@rohanKanojia please assign this to me.

baruKreddy avatar Jun 29 '22 16:06 baruKreddy

I left this one open because the 3rd point of the AC (Assertions should be replaced by AssertJ) was not addressed

manusa avatar Jul 06 '22 13:07 manusa

@baruKreddy : Could you please address AC which Marc just pointed out?

rohanKanojia avatar Jul 06 '22 13:07 rohanKanojia

Sure, will work on it!

baruKreddy avatar Jul 06 '22 14:07 baruKreddy