jkube icon indicating copy to clipboard operation
jkube copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-jkube

fix: FileAssertions related unit test failures

Open halfdreamer opened this issue 2 years ago • 7 comments

Description

Fix https://github.com/eclipse/jkube/issues/1409 Unit tests that use FileAssertions:fileTree is failing due to invalid expected file paths.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change
  • [x] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Checklist

  • [x] I have read the contributing guidelines
  • [x] I signed-off my commit with a user that has signed the Eclipse Contributor Agreement
  • [ ] I Added CHANGELOG entry
  • [ ] I have implemented unit tests to cover my changes
  • [ ] I have updated the documentation accordingly
  • [ ] No new bugs, code smells, etc. in SonarCloud report
  • [ ] I tested my code in Kubernetes
  • [ ] I tested my code in OpenShift

halfdreamer avatar Apr 07 '22 00:04 halfdreamer

Eclipse JKube CI Report

Started new GH workflow run for https://github.com/eclipse/jkube/pull/1428 (2022-04-07T01:06:58Z)

:gear: JKube E2E Tests (2105935508)

manusa avatar Apr 07 '22 00:04 manusa

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 07 '22 01:04 sonarqubecloud[bot]

@rohanKanojia could you please help with the build failure. Can we try re-running ci/circleci: doc-preview-pr step, seems like I don't have permission.

halfdreamer avatar Apr 07 '22 11:04 halfdreamer

Codecov Report

Merging #1428 (bc4b0d2) into master (ded7049) will not change coverage. The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #1428   +/-   ##
=========================================
  Coverage     51.02%   51.02%           
  Complexity     3796     3796           
=========================================
  Files           459      459           
  Lines         20683    20683           
  Branches       2809     2809           
=========================================
  Hits          10553    10553           
  Misses         9014     9014           
  Partials       1116     1116
Impacted Files Coverage Δ
...lipse/jkube/kit/common/assertj/FileAssertions.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ded7049...bc4b0d2. Read the comment docs.

codecov[bot] avatar Apr 07 '22 12:04 codecov[bot]

I remember this 😂 I fixed it as well as part of https://github.com/eclipse/jkube/pull/1416 but without recurring to the real path, which would break in case of non-existing paths (ie. mocks)

cdprete avatar Apr 11 '22 17:04 cdprete

@cdprete I guess we could close it as duplicate, once https://github.com/eclipse/jkube/pull/1416 is merged ?

sunix avatar Jun 13 '22 16:06 sunix

@cdprete I guess we could close it as duplicate, once #1416 is merged ?

Yep

cdprete avatar Jun 17 '22 08:06 cdprete

outdated

manusa avatar Mar 28 '24 15:03 manusa