Le Xuan Manh

icon company @KyberNetwork icon location Vietnam icon location We turn 🍕 and ☕ into codes

Results 15 comments of Le Xuan Manh

bad function call in conversion rate (pricing)

Fixed with new conversion rate contract in this PR: https://github.com/KyberNetwork/smart-contracts/pull/416/files

bad function call in conversion rate (pricing)

This issue should be resolved in enhanced step function contract

avoid assigning to function parameters

Fixed in https://github.com/KyberNetwork/smart-contracts/pull/422

block steps functions that create price raise

Addressed in https://github.com/KyberNetwork/smart-contracts/pull/422

enable to unlist permission less order book reserve when it has 0 rate (no orders)

In `PermissionlessOrderbookReserveLister` there is func `unlistOrderbookContract` to unlist reserve. It has stricter checks like knc rate to be higher than a certain value. So we want to create a similar...