Le Xuan Manh comments

Results 15 comments of


                                            Le Xuan Manh

I found a problem

Could be same as https://github.com/TrustWallet/trust-wallet-ios/issues/826

Generate mnemonic words slowly

Try to add `post_install do |installer| installer.pods_project.targets.each do |target| if ['JSONRPCKit'].include? target.name target.build_configurations.each do |config| config.build_settings['SWIFT_VERSION'] = '3.0' end end if ['TrustKeystore'].include? target.name target.build_configurations.each do |config| config.build_settings['SWIFT_OPTIMIZATION_LEVEL'] = '-Owholemodule' end...

Not a bug but a question on the project? Or where’s the project that encompass the MetaggregationRouter source code in order to Open a ᴘʀ at the correct place ?

Just copy the line here `_doTransferERC20(desc.srcToken, address(this), msg.sender, desc.amount - spentAmount);` In some cases, the srcToken is collected in the Router (like swap from native, or swap as a meta...

Not a bug but a question on the project? Or where’s the project that encompass the MetaggregationRouter source code in order to Open a ᴘʀ at the correct place ?

It's a private repo with Executor code, but Router is verified already > There’s no cases where the router’s balance of a token can decrease in this function -> This...

Not a bug but a question on the project? Or where’s the project that encompass the MetaggregationRouter source code in order to Open a ᴘʀ at the correct place ?

Yes, it intends to config and swap with other exchanges, whitelisted only. > there’s no cases where currBalance - routerInitialSrcBalance can yield a positive number => So we calculate `spentAmount...

Not a bug but a question on the project? Or where’s the project that encompass the MetaggregationRouter source code in order to Open a ᴘʀ at the correct place ?

The `swapGeneric` was used before with other exchanges which could support partial-fill, so all conditions are needed. Now we remove the support for swapGeneric, so yes, the decrease in ERC20...

Not a bug but a question on the project? Or where’s the project that encompass the MetaggregationRouter source code in order to Open a ᴘʀ at the correct place ?

It's not correct, please check: _transferFromOrApproveTarget It will approve the correct desc.amount to the target before calling to swap.

Not a bug but a question on the project? Or where’s the project that encompass the MetaggregationRouter source code in order to Open a ᴘʀ at the correct place ?

Not possible for now, since we don't use it anymore (from UI or API) we just initiated an operation to disable all whiteslited routers that we have enabled previously. If...

Not a bug but a question on the project? Or where’s the project that encompass the MetaggregationRouter source code in order to Open a ᴘʀ at the correct place ?

You can send any findings to my email at [email protected], potential bounty could be given for a valid unknown finding, depends on the severity and impact. If it is ok,...

overflow possible in get Imbalance - very low likliehood.

Adjusted in this PR https://github.com/KyberNetwork/smart-contracts/pull/422