smart-contracts icon indicating copy to clipboard operation
smart-contracts copied to clipboard

bad function call in conversion rate (pricing)

Open ilanDoron opened this issue 6 years ago • 2 comments

in conversion rate. https://github.com/KyberNetwork/smart-contracts/blob/02094d33d8d552adf8b4e58fbf38a3aabf27d12d/contracts/ConversionRates.sol#L227

call to getTokenQty(token, rate, qty);
rate and qty are swapped should be replaced by getTokenQty(token, qty, rate);

thanks to @namnm1991 for finding this bug...

ilanDoron avatar Aug 28 '18 07:08 ilanDoron

Fixed with new conversion rate contract in this PR: https://github.com/KyberNetwork/smart-contracts/pull/416/files

manhlx3006 avatar Aug 07 '19 07:08 manhlx3006

This issue should be resolved in enhanced step function contract

manhlx3006 avatar Aug 30 '19 07:08 manhlx3006