Malte Rohde
Malte Rohde
Try replacing all the `@example` references in the block at `trace_rspec.rb:45` and around with the block param `example`. Worked for me.
@nikolai-b Not sure I understand, what's the difference to `lock()` then? If it's only about the raise on error, why not do ```rb lock_info = client.lock(...) raise Redlock::LockError unless lock_info...
Hmm, the original implementation of this dates back before I stumbled into this gem :) I see what you mean now, and agree that the behaviour of `lock`/`lock!` is a...
PR looks good, change looks sensible to me. With regards to the API changes: Sure, technically incompatible, albeit maybe a minor case since it's on the error path anyway? However,...
Think this is way outdated now :)
IMO the great thing about `mix format` is that it allows us to move away from CI checks (i.e., `--check-formatted`) to a more user-friendly automated way of enforcing formatting. In...
Hey @pmeinhardt, I think we need to differentiate between auto-formatting and checking formatting in PRs more clearly. With regards to auto-formatting, I don't see a reason why using latest Elixir...
> Not too sure about that. There are some recent updates to the ssh_agent specs that are labeled with 23.0-rc2: Although they also replaced the `since="OTP 23.0"` with `since=""` everywhere......
@yordis > Do you mind expanding on that, do you mean you leaked to some 3rd party provider? Leaked to our application monitoring as part of its exception handling. >...
Also, as a side note: We have since discovered that we also use the `KeepRequest` middleware in one case, so we would also need to purge the `req_headers` from the...