Malte Rohde

Results 57 comments of Malte Rohde

Yeah, that one we could probably address. You're still using the `session_pool: [timeout: 30_000]` option, is that right? That isn't applied to the `NimblePool.checkout!/3` call, see [here](https://github.com/bitcrowd/chromic_pdf/blob/dd5aa3f9423a2fda18ff7aa5179f4f3afb381eb7/lib/chromic_pdf/pdf/browser/session_pool.ex#L55-L64). Mostly because I...

@markquezada addendum on my previous comment: @andreasknoepfle pointed out that you were only running a single test on CI, which I completely forgot in the meantime :) So I guess...

FWIW I tried setting up Github actions for this repository, and look at the first error that jumps in my face: ![image](https://user-images.githubusercontent.com/96114/205272828-033e3507-9936-4368-bb89-96259d5052c7.png) https://github.com/bitcrowd/chromic_pdf/pull/179 [edit] or look at this job: https://github.com/bitcrowd/chromic_pdf/actions/runs/3600997571/jobs/6066285321...

This one may be relevant https://github.com/microsoft/playwright/issues/4345

> > This one may be relevant https://github.com/microsoft/playwright/issues/4345 > Isn't that running headful chrome though? That ticket notes that headless chromimum is optimized for cold boots. Huh? AFAIK there is...

@markquezada Still on my way of getting the test suite to run on Github actions (see #179), but it's looking good, i.e. I don't have random delays anymore. Maybe give...

@markquezada I've looked into Github actions further today and established a few points: * The delay happens after `Port.open`, Chrome launches but takes a while to respond to our devtools...

Merged. Heads up, I renamed it to `warm_up/0`. Also added a mix task that can be run directly from a CI script, in case you don't need any options. Curiously,...

1. Split the postscript snippet (`PDFA_def_ext.ps.eex` or so) 2. Optionally render the postscript `info` snippet in the `GhostscriptWorker.join/2` function 3. Render both snippets in `GhostscriptWorker.convert/2`