Malte Kliemann

[PM] Use `twox_64_concat` hash function for `MarketIdsPer*`

1

I don't really see how users have much control over the keys here.

#683 demonstrates that our testing happens in a vacuum. We should add a test which (at the very least) verifies that the node is capable of producing blocks and responds...

[simple_disputes] Disputes resolve to last dispute without global dispute

1

On a market with `simple_disputes` as DRM, I can ping-pong disputes back and forth until `MaxDisputes` is reached. But then, instead of creating a global dispute, the market just resolves...

[primitives] `Swaps` trait seems incomplete

1

For example, `pool_join_with_exact_pool_amount` is missing.

[prediction-markets] Deposit warnings into `log` on accounting problems

2

In certain situations we need to make assumptions on the availability of funds. For example, when slashing the `AdvisoryBond` when rejecting an advised market, we make the assumption that the...

Currently, `admin_destroy_market` only works on markets with scoring rule `ScoringRule::CPMM`. Before we activate Rikiddo, this must be fixed. The required steps have already been identified: - https://github.com/zeitgeistpm/zeitgeist/pull/586#discussion_r871323256 - https://github.com/zeitgeistpm/zeitgeist/pull/586#discussion_r871318710

Cache account ids?

1

Regarding `account_id()`, the treasury pallet's documentation says the following about `into_sub_account`: > This actually does computation. If you need to keep using it, then make sure you cache the value...

[market-commons] Remove `now()` method from `MarketCommonsPalletApi`

2

The `now()` method of `MarketCommonsPalletApi` is used by `prediction-markets` to check for ending times of markets. Is there a reason why we refer to the `market-commons` pallet for the time,...

Audit how many markets can be closed/resolved per block

3

Resources for state transitions are limited. How many should be allowed per block?