zeitgeist icon indicating copy to clipboard operation
zeitgeist copied to clipboard

[prediction-markets] Deposit warnings into `log` on accounting problems

Open maltekliemann opened this issue 2 years ago • 2 comments

In certain situations we need to make assumptions on the availability of funds. For example, when slashing the AdvisoryBond when rejecting an advised market, we make the assumption that the bond is actually reserved for the market creator. This assumption is correct if our code is correct.

But it would be good to receive a warning message if there's an accounting problem. We already have this in place in some places, but should have this everywhere.

maltekliemann avatar May 10 '22 19:05 maltekliemann

I think that this is an important point. We have not complete transparency of misbehavior of the chain, and when such things as you mentioned happened, the node should definitely log this to make us aware of such things happening. Increasing the priority to medium.

sea212 avatar Jul 10 '22 14:07 sea212

This is fixed with regards to bonds, but somebody should check if there's anything else that should be logged.

maltekliemann avatar Oct 25 '23 00:10 maltekliemann