Matt Liberty
Matt Liberty
@eder-matheus there is a secure CI running for this and so far it looks good. Please take a look tomorrow and see if it mergeable with some minor metrics updates.
> A PR for ORFS will be created after this PR is merged. Its good to have both ready so they can be merged at the same time. You only...
@precisionmoon this is somewhat old - not sure if your recent work has solved this.
There is a huge change in insertion delay before and after timing repair. Do you know what accounts for that? Is it related to repair_clock_net?
I meant that the scale on the left side of the graphs is substantially different ~400 vs ~1400
I see many resolved comments but not the usual clang-tidy thumbs-up. Is there something not yet resolved?
Thanks for the clang-tidy info. I find its static analysis to not be very good and keep considering disabling it completely as it has a high false positive rate.
#4617 and this PR are about to contend on the db schema. Would you be ok if that one goes first and you take the merge?
ready for review or still working?
It would be good to have descriptive comments for the new classes in db.h