Matt Liberty comments

Results 1724 comments of


                                            Matt Liberty

make write_* commands to write out files atomically

Please also note you are missing DCO and need to run clang-format before the merge.

make write_* commands to write out files atomically

I already made the same suggestion above: `std::tmpnam or std::tmpfile should be used.`

make write_* commands to write out files atomically

POSIX has tempnam (not tmpnam) which allows a directory specification if that is helpful.

make write_* commands to write out files atomically

> POSIX has tempnam (not tmpnam) which allows a directory specification if that is helpful. You can give directory and file name prefix which could be ".odb". It seems like...

make write_* commands to write out files atomically

Thanks for contributing!

make write_* commands to write out files atomically

The nit picking can migrate to #5181

Run GUI with TSAN

I can't pick out a clear issue from that. Does it make sense to you?

Run GUI with TSAN

@QuantamHD waiting on your PR for TSAN

gpl: replace FastRoute with Rudy on gpl routability driven mode

Where does this stand with CI/metrics? Are any updates needed?

New "Incremental Routing" broke detailed routing

No more info is needed for now. This week will be slow as several people at ETH Zurich.