Max Kotliar

Results 174 comments of Max Kotliar

How can I help?

> I had error_reporting set to default on my machine, which is why they passed for me, might want to set that in bootstrap. yes, please add that.

I just thought of usecase. Can you give a real life example where it could be helpful.

honestly I dont like the prefix `UniversalErrorCatcher_` before Exception classes. Also the context usage is more drupal special case and I dont see other ways to use it. So what...

I've got your point. so let create protected: - createErrorException() - createSuppressedErrorException() - createFatalErrorException() methods. sure with context as last parameter. so you can overwrite it. > BTW, you could...

those the methods will add one more level to stack trace: ``` Catcher::createErrorHandler Catcher::handleError ... ``` from this point of view exception class configuration is better.

> Regarding the Exceptions names, I was saying if you want a short name for users to catch, you could do that with an interface and have everything else follow...

> Sounds good, totally another issue. maybe in this case the lib could provide: - ExceptionInterface - ErrorExceptionInterface - SuppressedErrorExceptionItnerface - FatalErrorExceptionInterface ?

If someone overwrite `relying_party` option of firewall. the recovered_ error relying party will be lost. So the redirect described in this doc: https://github.com/formapro/FpOpenIdBundle/blob/master/Resources/doc/interactive_user_creation.md would not work. ``` return $this->redirect($this->generateUrl('fp_openid_security_check', array(...

update values lib version in composer. it installed the old one.