Max Kotliar

Results 174 comments of Max Kotliar

or in symfony https://github.com/Payum/Payum/blob/master/docs/symfony/custom-purchase-examples/klarna-checkout.md

> Payum has a "pending" status, but is not for this scenario, it's used when we waiting for a push notification from PayPal. I disagree on this, The pending status...

Here's the code responsible for status calculation: https://github.com/Payum/Payum/blob/master/src/Payum/Paypal/ExpressCheckout/Nvp/Action/PaymentDetailsStatusAction.php#L17 There is a bug in that logic, I guess.

not in your logic, but in payum's, must be fixed

If you have this in details ``` details( ... "ACK" => "Success", ... "CHECKOUTSTATUS" => "PaymentActionCompleted" ... "PAYMENTINFO_0_PAYMENTSTATUS" => "Pending", "PAYMENTINFO_0_PENDINGREASON" => "paymentreview", ... ) ``` This condition has to...

One idea that we may use PAYMENTINFO_0_PAYMENTSTATUS https://github.com/Payum/Payum/blob/master/src/Payum/Paypal/ExpressCheckout/Nvp/Action/PaymentDetailsStatusAction.php#L96 here

> I think keeping payum/payum as a mono-repo that contains all the packages has its benefits and it makes a lot of integration and development a lot easier. This repo...

If change json_array to json are there any BC breaks ?