Max Kotliar

I suppose It should send [amqp.ErrClosed](https://github.com/makasim/amqpextra/blob/350c5620b4add78833bef5721e969c72cef0a2fa/publisher/publisher.go#L373) to all pending messages, wait till it is [done](https://github.com/makasim/amqpextra/blob/350c5620b4add78833bef5721e969c72cef0a2fa/publisher/publisher.go#L320) and exit. Ideally you should stop publishing, wait till all pending messages are published and...

I gave it another though and It looks like there is room for improvement. Here https://github.com/makasim/amqpextra/blob/master/publisher/publisher.go#L365 we can catch graceful stop and give some time for messages to catch up.

By closing contexts in proper order. You have some inputs and outputs in your app, and a pipeline in between. So, you have to start stopping the app from inputs...

Consider using https://github.com/thejerf/suture

https://github.com/makasim/amqpextra provides good foundation for connection pool. The pool is not implemented yet but will be there someday. For now, you can create a bunch of dialers and subscribe to...

@mmucklo feel free to ask any questions.

@wagnert feel free to ask any questions!

You should serialize it, for example into json or xml. There is no way you can send a php object as is.

Why double? Your code encodes a data to JSON so it becomes a string, then send it as the message body. In turn, on a consumer side, you get a...

> Ommiting string typehint does not couple encoding\decoding logic. Most of the transports accept only a string. What should those transport do if something else given? It would force us...