maitrayshah-cb

Hi @houllette, apologies for the delayed reply, someone (me) dropped the ball there. It is definitely a great idea to get it merged in the main branch and also expanding...

@houllette We added a [doc](https://github.com/coinbase/salus/blob/master/docs/adding_scanner.md) detailing some information on how to add a scanner. Feel free to take a look at that and suggest any improvements we can make to...

Below should help pass the tests - Adding `"Sobelow"` to this list - https://github.com/coinbase/salus/blob/5d6b2777632ae5d186ef947ac3d56851df1f30db/spec/fixtures/processor/local_uri/expected_report.json#L62 Adding JSON object ``` "Sobelow": { "pass_on_raise": false, "scanner_timeout_s": 0 }, ``` to https://github.com/coinbase/salus/blob/5d6b2777632ae5d186ef947ac3d56851df1f30db/spec/fixtures/processor/local_uri/expected_report.json#L103

Similarly adding - Adding `"Sobelow"` to this list - https://github.com/coinbase/salus/blob/5d6b2777632ae5d186ef947ac3d56851df1f30db/spec/fixtures/processor/remote_uri/expected_report.json#L62 Adding JSON object ``` "Sobelow": { "pass_on_raise": false, "scanner_timeout_s": 0 }, ``` to https://github.com/coinbase/salus/blob/5d6b2777632ae5d186ef947ac3d56851df1f30db/spec/fixtures/processor/remote_uri/expected_report.json#L103

@alex0112 Thanks for adding this, I'll take a look and if everything looks good will merge it in.

@alex0112 Yeah I think my bad, while resolving conflict I messed up the config file. Essentially just make sure it matches this block - https://github.com/coinbase/salus/blob/e732912847a39450e6d7f17dd7b3e715c30a5da5/spec/fixtures/processor/local_uri/expected_report.json#L54 and has an object for...

Gonna hold off on this one, since this changed default behavior.