salus icon indicating copy to clipboard operation
salus copied to clipboard

Add Support for Sobelow (Elixir)

Open houllette opened this issue 2 years ago • 3 comments

We've been using Salus for awhile now at my current company and have integrated Sobelow into it for the purposes of scanning Elixir code.

Our implementation is not ready for primetime via a PR and we're unsure if we have time to dedicate to cleaning up our fork so it's ready for a PR; so we'd love some assistance getting it integrated from official maintainers so we don't have to continue supporting our fork as it drifts further and further away from the main branch.

houllette avatar Jun 02 '22 18:06 houllette

Hi @houllette, apologies for the delayed reply, someone (me) dropped the ball there. It is definitely a great idea to get it merged in the main branch and also expanding support to a new language. Unfortunately, I am not sure how much time we can commit at this point right now but let me check with the team. That said we've had request to publish more documentation around "How to write a scanner" which is being worked on so I can try and get those out to you if that helps.

maitrayshah-cb avatar Jun 24 '22 16:06 maitrayshah-cb

No worries, @maitrayshah! More documentation would be significantly helpful! There are some ideas floating around internally to dedicate some resources to making the merge a reality, so those docs good come in handy real soon! Thanks!

houllette avatar Jun 24 '22 21:06 houllette

@houllette We added a doc detailing some information on how to add a scanner. Feel free to take a look at that and suggest any improvements we can make to it. Thanks

maitrayshah-cb avatar Jun 28 '22 18:06 maitrayshah-cb