Magnus Ihse Bursie
Magnus Ihse Bursie
Sounds like this should be a `feat!` when it is integrated. You're doing a massive amount of work here, @ShadowCat117, thanks!
It looks good overall. This is not a thorough review though.
> I don't know why ASAN cares about the library order or the implications thereof. My understanding is that it wants to be injected first, and if you do LD_PRELOAD...
All the original labels are still there. A better approach had probably been to close the PR and open a new. You either need to do that now, or delete...
The big question here, I think, is really: should we keep the vanilla quest book as the core of the GUI, and just extend/enhance it, or should we continue doing...
> Or maybe LTO is breaking us in some other way (such as taking advantage of no-UB constraints that aren't found by normal compilation). That seems definitely likely. With LTO...
Oh. Hm. I think I see the issue. Do you think there is any set of common attributes, or do they need to be completely separate?
Ok. I think we have two possibilities, either make like MapLocationAttributes inherit and extend MapAttributes, or let MapLocation have a second method `getLocationAttributes` that returns a free-standing MapLocationAttributes. Both solutions...
If we go by route 3, we can add some checking when reading a json file and emit a warning if irrelevant attributes are used, perhaps? Or wait, we can't...
Unless we internally also want to have categories which provide attributes to multiple classes of features. Like lootruns, it might make sense to have that, right?