Magnus Ihse Bursie
Magnus Ihse Bursie
This does not seem correct. You will fail to parse coordinates that contain 0.
I strongly recommend that you fix this by test-driven development -- that is, start by writing a set of tests of the regexp, both ones that should work right now...
Also, I think you can in any case reduce the number of digits to 5. I don't think Wynn uses any coordinates ouside 99999.
I'm mostly worried about coordinates for quest-specific partial maps. They can be larger than 9999, I think.
This looks generally better, I think. I'm perhaps a bit worried about the requirement of whitespace, but then again, this is only the strict matching. We do have a non-strict...
`(?:[\\s,]{1,2}` looks just plain wrong. I had not noticed that. *sigh* Regexes are really write-only code. It might be time to retire the entire existing expression and create a new...
@JamieCallan117 This looks like major improvements in usability!
These changes all look great! I am very happy to see that you're taking the time needed to make these improvements.
> I also failed at squashing so can mostly ignore the first ~15 commits At some points it's easier to make a diff relative to main, and apply that diff...
You can move the party overlay so it does not collide with the chat window.