magento-coding-standard

magento-coding-standard copied to clipboard

Changes included in this pull request: - update list of void elements - automatically fix closing tags when possible - annotate the offending lines not the file

fredden

Magento2\Sniffs\Legacy\RestrictedCodeSniff doesn't catch namespaced classes

1

### Preconditions 1. Magento 2.4.5-p1 2. Magento Coding Standard v29 ### Steps to reproduce 1. Create a php file, where you include any namespaced class from [restricted_classes.php](https://github.com/magento/magento-coding-standard/blob/develop/Magento2/Sniffs/Legacy/_files/restricted_classes.php) for example [\Magento\Framework\Serialize\Serializer\Serialize](https://github.com/magento/magento-coding-standard/blob/v29/Magento2/Sniffs/Legacy/_files/restricted_classes.php#L337)...

DmitryFurs

While working on https://github.com/magento/magento2/pull/37020, I noticed that the Magento coding standard was requiring a docblock comment for the following constructor: https://github.com/magento/magento2/blob/322047d01d98b584892c6058ed93c5bf6715add8/lib/internal/Magento/Framework/Data/Tree.php#L28-L33 ```php public function __construct() { $this->_nodes = new NodeCollection($this);...

fredden

Less files: valid Less contruction parsing issue

1

### Preconditions 1. Example of the less file ``` .mixin-example(@my-selector) { .@{my-selector} { background: #fff } } .mixin-example(input-box) ``` 2. Magento v2.4.5-p1 3. PHP v8.1 4. magento/magento-coding-standart v29 ### Steps...

JuiceBlynskyi

Exception class Magento\Framework\Validator\ValidateException does not exist

2

### Preconditions Add attribute in Data Patch using `$eavSetup->addAttribute()` method. Place DataPatch in Vendor/Module/Setup/Patch/Data/AddTestAttribute.php file. Example ```php $eavSetup = $this->eavSetupFactory->create(['setup' => $this->moduleDataSetup]); $eavSetup->addAttribute(Product::ENTITY, $attributeCode, $attribute); ``` ### Steps to reproduce...

okolya

Too strict or early rule for Zend_Validate

6

### Steps to reproduce 1. Use Zend_Validate in your extension 2. Validate extension with the last (26) version of Magento Coding Standard ### Expected result 1. Extension is not valid...

06romix

Forbid Framework\Module\Status::setIsEnabled

1

### Rule Forbid calling Magento\Framework\Module\Status::setIsEnabled ### Reason Experienced downtime as a result of a magento marketplace module (feefo/reviews) calling setIsEnabled(true) in production mode. The target was Magento_Review, which was installed...

maaarghk

Fixes #477

fredden

Rule Magento2.Exceptions.TryProcessSystemResources should exclude warnings from "use function .." section

3

### Description There is a false waring case when current sniffer rule detects system resources functions (stream_, socket_) declared in the "**use function** .." section. ### Expected behavior When system...

ed007m

https://jira.corp.adobe.com/browse/AC-12039

yaroslavGoncharuk