magento-coding-standard
magento-coding-standard copied to clipboard
Too strict or early rule for Zend_Validate
Steps to reproduce
- Use Zend_Validate in your extension
- Validate extension with the last (26) version of Magento Coding Standard
Expected result
- Extension is not valid and there is a correct suggestion or it is not ERROR level but WARNING
- Suggested replacement is present in 2.4.0 Magento versions as it is supported to November 28, 2022
Actual result
- Extension not valid
- Suggested replacement (\Magento\Framework\Validator\ValidatorChain) is missing in 2.4.0-2.4.5
Pull request #420 bring these new changes.
Hi @06romix. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this
- Join Magento Community Engineering Slack and ask your questions in #github channel.
Agree that this is way too early.
Even the current deployed version by Magento (2.4.5) is not fully working with this rule.
For example, check this file => https://github.com/magento/magento2/blob/2.4.5/app/code/Magento/Eav/Setup/EavSetup.php#L825
Using the EavSetup in custom code leads to this error of coding standards while this is not fully imported yet in Magento side.
Yes, just discovered the same issue here.
Definitely a bad thing to error out with a suggested replacement that does not even exist in any stable/supported Magento version.
We also have the same issue.
same issue, plus Suggested replacement: Magento\Framework\Validator\ValidateException class is missing