magento-coding-standard

magento-coding-standard copied to clipboard

False Positive: Magento2.Legacy.InstallUpgrade.ObsoleteInstallDataScript

1

### Preconditions 1. Package contains data patch `\VendorName\ModuleName\Setup\Patch\Data\InstallData` (exact nature of data patch irrelevant) ### Steps to reproduce 1. Run the coding standard against the file `Setup/Patch/Data/InstallData.php` ### Expected result...

dfelton

Less files : Class name separator issue

3

### Preconditions M2.4.4 Coding standard v25 ### Steps to reproduce 1. Create a module 2. Add file view/css/source/_module.less with content : ``` /** * @DoNotInject */ .admin__menu { .item-mymodule.level-0 {...

Nuranto

Do not require DocBlock for typed class attributes

1

### Description Do not require a DocBlock for typed class attributes ### Expected behavior Class attributes that have specified types should not require a DocBlock. When an attribute already has...

aligent-lturner

Expected 1 space after colon with &:not(:first-child)

8

### Preconditions 1. In a less file if you use &:not(:first-child) it generates spacing warnings. ### Steps to reproduce 1. Use &:not(:first-child) in a less file. 2. Run the coding...

Sental

Magento2.Legacy.InstallUpgrade.ObsoleteUpgradeSchemaScript ERROR on --severity=10

3

Magento2.Legacy.InstallUpgrade.ObsoleteUpgradeSchemaScript rule fails on marketplace with ERROR on on --severity=10 application submission. - Marketplace allows you to submit packages supporting 2.2 where UpgradeSchemaScript was not obsolete yet - Before Magento...

speedupmate

Allow Use of Template Literals

1

https://eslint.org/docs/rules/quotes We shouldn't deter people from making code more readable. ### Resolved issues: 1. [x] resolves magento/magento-coding-standard#403: Allow Use of Template Literals

pykettk

This issue is automatically created based on existing pull request: magento/magento-coding-standard#364: Allow Use of Template Literals --------- https://eslint.org/docs/rules/quotes We shouldn't deter people from making code more readable.

m2-assistant[bot]

Exclude xml files for LineLength rule ?

3

I don't think having LineLength rule for xml is relevant. With XML indentation and a lot of nested tags (ie. system.xml), or with some tags that must have a full...

Nuranto

@author MUST NOT be used.

4

### Rule @author MUST NOT be used ### Reason As per magento DocBlock document (https://devdocs.magento.com/guides/v2.3/coding-standards/docblock-standard-general.html#documentation-space) Structure of documentation space @author ,@category, @package, and @subpackage MUST NOT be used. Documentation is...

arushibansal013

"Avoid using self-closing tag" rule is false positive with inline svg

2

As SVG content must be in XML format it must be excluded from HTML validation. ### Preconditions 1. Installed Magento Coding Standard V19 or above ### Steps to reproduce 1....

plumrocket