Thomas Fuchs
Thomas Fuchs
Is `key.noConflict` not enough? What's the use case here and how would you imagine at this to work (any patch should be backwards-compatible with earlier versions of keymaster).
@toots You realize that keymaster comes with automated tests that tests triggering keys with the proper DOM events for this?
@ajb not everyone needs this, that's why the filter function is easily overridable. I'd merge a PR with extensive tests tho. It needs detection of the browser supports `isContentEditable`, I...
Hi there. Thanks for PR. It’s missing tests to demonstrate what has been fixed. Would you mind adding them?
The library is already taking up no space ¯\_(ツ)_/¯
Especially issues and pull requests!
Can't say for sure (it's been a while), but `zepto.qsa(...)` looks like it is faster and can be minimized better. You're probably right that the other code can be optimized...
Hi there, does anybody in here have a PR w/ tests that we can apply?
Could you please provide a full example and point out where it fails and what the expected result is? Ideally use something like https://codepen.io. Thanks!